Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): handle when auto_install is set to false #24

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

boltlessengineer
Copy link
Contributor

minor fix for when auto_install is set to false

config.auto_install = opts.auto_install ~= nil and opts.auto_install or config.auto_install

When opts.auto_install is set to false, config.auto_install becomes ”prompt” because of how lua ternary works.1
true and false or “prompt” in lua is ”prompt”

Footnotes

  1. https://lua-users.org/wiki/TernaryOperator

@boltlessengineer
Copy link
Contributor Author

Just swapping the condition should work but lua-language-server doesn’t seem to like it.

Copy link
Member

@NTBBloodbath NTBBloodbath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch :)

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb merged commit 3d19180 into nvim-neorocks:main Jul 31, 2024
3 checks passed
@mrcjkb mrcjkb mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants